search

joypixels / emojione

[Archived] The world's largest independent emoji font. Maintained at https://github.com/joypixels/emoji-toolkit.
https://www.joypixels.com
Other
4.46k stars 535 forks source link

Some Family and Couple Shortnames Display Multiple Emojis #310

Closed msong2 closed 7 years ago

msong2 commented 8 years ago

Some family and couple shortnames don't display correctly using the shortnameToUnicode and UnicodeToImage functions. For example, in the jsfiddle link, ": kiss_ww :", ": couple_mm :", and ": couple_ww :" don't show properly. However, using the shortnameToImage method displays the emojis correctly.

https://jsfiddle.net/545jt38n/6/

caseyahenson commented 8 years ago

@mson2 thank you for pointing this out! We're looking more into this now and hopefully with publish a solution soon.

Andy6792 commented 8 years ago

Thanks @caseyahenson - I've noticed this also.

Crissov commented 8 years ago

In the jsfiddle, it‘s not only ZWJ sequences, though: :heart: becomes U+2764-FE0F (VS-16): ❤ vs. ❤︎ vs. ❤️. You should also test Fitzpatrick modifiers, e.g. :baby_tone4: U+1F476-1F3FE 👶🏾.

Would perhaps be fixed by #320 and #290 also seems related.

Crissov commented 8 years ago

It’s definitely the variation selector (U+FE0F) that’s tripping up unicodeToImage().

Andy6792 commented 8 years ago

Just wondering if there is any update on this? 👍

caseyahenson commented 7 years ago

This issue should be resolved in the 2.2.7 update. Loading the 2.2.7 library into the fiddle posted above (https://jsfiddle.net/545jt38n/6/) shows all images loading properly.