search

joypixels / emojione

[Archived] The world's largest independent emoji font. Maintained at https://github.com/joypixels/emoji-toolkit.
https://www.joypixels.com
Other
4.46k stars 533 forks source link

Fix issue 551 #553

Open anamauad opened 7 years ago

anamauad commented 7 years ago

Fixed #551 and added test cases for it.

Function shortnameToImage was searching for :+1: instead of :\\+1: in ns.shortnames.

Function shortnameToUnicode was searching for :+1: in emojiList, but :+1: is an alternate shortname of :thumbsup:. It was updated to search in ns.shortnames and then searched for in parents.

anamauad commented 7 years ago

There is a problem with the build in CI tool: UNMET PEER DEPENDENCY grunt@1.0.1

Maybe the npm needs to be upgraded, according to: https://stackoverflow.com/questions/38552527/having-this-error-unmet-peer-dependency-grunt1-0-1