search

joypixels / emojione

[Archived] The world's largest independent emoji font. Maintained at https://github.com/joypixels/emoji-toolkit.
https://www.joypixels.com
Other
4.46k stars 533 forks source link

Fix PHP asciiToShortnameCallback (called on ASCII to shortname conversion) #603

Open icebird93 opened 6 years ago

icebird93 commented 6 years ago

When converting ASCII smileys using asciiToShortname, asciiToShortnameCallback is called. This function executes array_flip(array_reverse($ruleset->getShortcodeReplace())); that always results in an empty array, replacing ASCII smileys with empty strings. Also, function should return shortnames for smileys and not their unicode equivalents, therefore only $ascii_replace is needed.