joypixels / emojione

[Archived] The world's largest independent emoji font. Maintained at https://github.com/joypixels/emoji-toolkit.
https://www.joypixels.com
Other
4.46k stars 535 forks source link

output: null in eac.json for EmojiOne 4 #612

Closed maximbaz closed 6 years ago

maximbaz commented 6 years ago

@caseyahenson I noticed in eac.json some output fields became null.

    "00a9": {
        "output": null,          <----------------------------------------
        "name": "copyright",
        "alpha_code": ":copyright:",
        "aliases": ""
    },
    "00ae": {
        "output": null,          <----------------------------------------
        "name": "registered",
        "alpha_code": ":registered:",
        "aliases": ""
    },
    "203c": {
        "output": null,          <----------------------------------------
        "name": "double exclamation mark",
        "alpha_code": ":bangbang:",
        "aliases": ""
    },
    ...

I'm relying on this field to properly render emojis, and previously they were correctly filled. Is this a bug in the tool used to generate this file?

image

caseyahenson commented 6 years ago

@maximbaz good catch, I'll get this updated today

maximbaz commented 6 years ago

@caseyahenson I see you were updating the files, posting just in case you didn't notice, there are still some differences comparing to the file with emojione 3:

image

image

caseyahenson commented 6 years ago

check these newest files, @maximbaz. These should be solid

maximbaz commented 6 years ago

Look perfect, thanks a lot!