joypixels / emojione

[Archived] The world's largest independent emoji font. Maintained at https://github.com/joypixels/emoji-toolkit.
https://www.joypixels.com
Other
4.46k stars 536 forks source link

Keyboard Extension : Broken arrow keys navigation #620

Closed glutamatt closed 5 years ago

glutamatt commented 5 years ago

I'm not able to navigate through emojis with keyboard arrow keys.

EmojiOneTM for Chrome, version 4.0

I tried to debug a bit

closestEmoji: function(sourceEmoji, direction) {
      var closer, closest, emoji, emojis, i, leftDifference, len, offset, sourceOffset, topDifference;
      emojis = this.allEmojis();
      closest = null;
      sourceOffset = $(sourceEmoji).offset();
      for (i = 0, len = emojis.length; i < len; i++) {
        emoji = emojis[i];
        if (emoji === sourceEmoji || !emojis.hasOwnProperty(emoji)) {
          continue; // HERE : this continue seems to be always reached
        }
caseyahenson commented 5 years ago

This has been fixed!