Update get_goes_sequence for readability and testability

joyprojects / wildfire

This is a repository for working with GOES satellite data to model Wildfires.

MIT License

1 stars 1 forks source link

Update get_goes_sequence for readability and testability #59

Closed camenpihor closed 4 years ago

camenpihor commented 4 years ago

Some code changes and location changes to promote readability, testability, and cleanliness.

Changes

Abstract out creating a pooled function for testability
Pool over read_netcdfs instead of _download_sequence so that we don't have to deal with pickling for readability
Make creating time range functionality more abstract for readability and cleanliness

camenpihor commented 4 years ago

@Ferrumofomega you were mentioning that you wanted to write some tests so I left the testing of goes.utilities.create_time_range and goes.utilities.pool_function to you! want to pair on it?

Ferrumofomega commented 4 years ago

@Ferrumofomega you were mentioning that you wanted to write some tests so I left the testing of goes.utilities.create_time_range and goes.utilities.pool_function to you! want to pair on it?

Yes! I'll fiddle with it a bit tonight, too.