search

joyrex2001 / castools

This is a set of tools which can read sampled MSX tapes and convert them to the standard .cas format and back to .wav samples. This package consist of three tools: wav2cas, cas2wav and casdir.
GNU General Public License v2.0
38 stars 6 forks source link

Incorrect wav header errormessage #3

Closed mtarenskeen closed 7 years ago

mtarenskeen commented 7 years ago

I am getting "Incorrect wav header" error message with wav2cas, compiled from git sources version 1.31. But after I defined unint32_t as unsigned int instead of unsigned long in wav2cas.c, conversion of my wav files to cas files works fine now.

I don't know enough about this subject to tell if this is a bugfix or an ugly workaround. I am using Linux Fedora 25, 64 bits, gcc 6.3.1

Just reporting.

nataliapc commented 7 years ago

You are right, it must be uint32_t, and others typedef from , for compatibility with 64bits systems.

joyrex2001 commented 7 years ago

Would it make sense to just add #include to fix this?

mtarenskeen commented 7 years ago

On Wed, 1 Mar 2017, Vincent van Dam wrote:

Would it make sense to just add #include to fix this?

Yes, it would. Unfortunately it still fails for me. I or it must still be missing something.

You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.[ADWMOAKu_R44osYqH_XJRPwfb63sprd-ks5rhcmvgaJpZM4MMUow.gif]

joyrex2001 commented 7 years ago

I removed the typedefs, and replaced it for the stdint solution. I tested it with ubuntu-trusty-64 (and OSX) and that worked, I hope this works for you as well... https://github.com/joyrex2001/castools/commit/2de25276b706d891fab1b51cfed1406ea74c4c52

mtarenskeen commented 7 years ago

On Mon, 6 Mar 2017, Vincent van Dam wrote:

I removed the typedefs, and replaced it for the stdint solution. I tested it with ubuntu-trusty-64 (and OSX) and that worked, I hope this works for you as well... 2de2527

Yes, it also works on my Fedora 25 (64 bits) system. Thanks.

Maybe someone can try compiling and testing on 32 bits and Windows systems.

--

MT

joyrex2001 commented 7 years ago

I have tested on an older 32-bit platform as well, and other than removing the "no-unused-result" warning option for newer gcc's, I had no issues. Thanks for your help guys!