joyrex2001 / kubedock

Kubedock is a minimal implementation of the docker api that will orchestrate containers on a Kubernetes cluster, rather than running containers locally.
MIT License
226 stars 33 forks source link

Return 404 if file does not exist on pod #60

Closed Blarc closed 1 year ago

Blarc commented 1 year ago

I've added a method for checking if file exists on pod before executing other command that will fail if file does not exist. This way we can return 404 Not Found error if file does not exist instead of 500.

I've had a problem with running elasticsearch testcontainers, because their error handling only checks for 404 and not for 500.

I've tested this with custom integration tests: docker_test.zip.

joyrex2001 commented 1 year ago

Thanks, looks good!