search

joyrider3774 / PlayniteSound

An extension for playnite to play audio during events
https://joyrider3774.github.io/PlayniteSound/
MIT License
21 stars 6 forks source link

[PoC]Added very basic support of theme Pause/Resume music and Music name #57, #63 #78

Open ashpynov opened 6 months ago

ashpynov commented 6 months ago

Please Here a PR to implement on 'old' version of extension abilty to integrate with theme to Pause/Resume music and expose current music name.

As soon as there is new extension major version development - I done modification to be as small as possible.

Information how to use it in theme added to readme.

cnapolit commented 5 months ago

Hey @ashpynov! Sorry for letting this PR linger for so long. The plans I had for developing this plugin were interrupted by a lot of unexpected road blocks.

As you might have noticed, I work out of a fork (https://github.com/cnapolit/PlayniteSound) that I merge into this repo once I'm ready for the next release. This fork is drastically different than the current state of this repo, with even more changes I have yet to commit. Thus, there would be some stellar conflicts that will be easier to handle via a fresh branch.

With that in mind, I'll try and finalize all the changes I have locally and let you know once it's complete. After which, we can try and work in the fundamental idea behind these changes.

I will still look through this PR and drop a comment here and there.

If at any point you want to chat more directly, feel free to message me over discord. Text or audio both work for me.

ashpynov commented 5 months ago

Hey @ashpynov! Sorry for letting this PR linger for so long. The plans I had for developing this plugin were interrupted by a lot of unexpected road blocks.

As you might have noticed, I work out of a fork (https://github.com/cnapolit/PlayniteSound) that I merge into this repo once I'm ready for the next release. This fork is drastically different than the current state of this repo, with even more changes I have yet to commit. Thus, there would be some stellar conflicts that will be easier to handle via a fresh branch.

With that in mind, I'll try and finalize all the changes I have locally and let you know once it's complete. After which, we can try and work in the fundamental idea behind these changes.

I will still look through this PR and drop a comment here and there.

If at any point you want to chat more directly, feel free to message me over discord. Text or audio both work for me.

Please consider this PR as Proof-Of-Concept. I will support this functionality in my modded version till you will complete your part of work. Then I will try reimplement approved/confirmed ideas on new codebase.