jozefizso / SystemWrapper

.NET library for easier testing of system APIs.
Microsoft Public License
175 stars 62 forks source link

Missing Methods on IEnvironment #14

Closed wiltaylor closed 6 years ago

wiltaylor commented 8 years ago

Main ones of note are ExpandEnvironmentVariables and GetFolderPath but the other ones are missing too.

astanula commented 7 years ago

This is rather kind of a bug rather then enhancement. Anything missing prevents the user from using a wrapper because he would need to have some parts implemented with SystemWrapper and other with something else, which is really very odd.

jozefizso commented 7 years ago

Methods ExpandEnvironmentVariables() and GetFolderPath() added in release v0.15

jozefizso commented 7 years ago

Bug would imply there is problematic behavior in the wrapper implementation.

This is an enhancement + help wanted as it requires extending existing interface in SystemWrapper.

Anybody missing functionality in the SystemWrapper is free to implement it and create pull request.

cjbush commented 7 years ago

I have a pull request open for this: https://github.com/jozefizso/SystemWrapper/pull/24

jozefizso commented 6 years ago

Please reopen if you miss other methods.