search

jozefizso / SystemWrapper

.NET library for easier testing of system APIs.
Microsoft Public License
175 stars 62 forks source link

ZipFileWrap.Open does not pass Encoding parameter #47

Closed daveorourke closed 6 years ago

daveorourke commented 6 years ago

On this line, the Encoding parameter that is passed to ZipFileWrap.Open should be passed into ZipFile.Open https://github.com/jozefizso/SystemWrapper/blob/develop/SystemWrapper/IO/Compression/ZipFileWrap.cs#L41

Zip files created with .NET 4.6.0 are not cross platform compatible, because they use backslashes instead of forward slashes. This is fixed in .NET 4.6.1. We stumbled on the bug in ZipFileWrap because we were using this Stack Overflow workaround to get cross platform zip files. Later, when we started using ZipFileWrap, this code stopped working. This was traced to the bug on the above line where the Encoding parameter is not passed to the underlying .NET class.

daveorourke commented 6 years ago

Thanks for fixing this @jozefizso. 👍

jozefizso commented 6 years ago

Released in 0.24.0.177