search

jozefizso / SystemWrapper

.NET library for easier testing of system APIs.
Microsoft Public License
175 stars 62 forks source link

ZipFileExtensions #53

Closed alexleen closed 6 years ago

alexleen commented 6 years ago

ZipFileExtensions

Allows for use of ZipFileExtensions without accessing the Instance property.

alexleen commented 6 years ago

@jozefizso please review and merge at your earliest convenience.

jozefizso commented 6 years ago

It looks good. I'm just curious why are both .csproj files completly changed? Is it whitespace changes or something like that?

alexleen commented 6 years ago

Yeah, if you hide whitespace changes the only thing that has been added is <Compile Include="IO\Compression\ZipFileExtensionsTests.cs" /> in SystemWrapper.Tests/SystemWrapper.Tests.csproj and <Compile Include="IO\Compression\ZipFileExtensions.cs" /> in SystemWrapper/SystemWrapper.csproj.

jozefizso commented 6 years ago

When I download the patch file, the .csproj files contain CRLF line endings. They should have LF in the diff.

alexleen commented 6 years ago

Oh, good catch. Fixed.

alexleen commented 6 years ago

Ready to merge, @jozefizso?