search

jozefizso / generator-license

Yeoman Generator - License
MIT License
59 stars 20 forks source link

Add subDir option #52

Closed fyrkant closed 7 years ago

fyrkant commented 7 years ago

Hi!

I am using your wonderful generator in a generator I am building but I would like put the generated LICENSE file in sub-directory in the generated project, not in the root. I couldn't find a way to do this right now so I made this pull request to add a subDir option that allows just that.

Cheers!

ek9 commented 7 years ago

I had a look and personally I think it would be a lot better idea just to introduce single "Output File" question. It can default to LICENSE, while allowing you to specify path/LICENSE instead. That would be way more natural for general use, instead of answering a weird question about sub-directory all the time when this does not apply to you.

I'd think this way also makes generator a bit less composable.

fyrkant commented 7 years ago

This PR does not add a prompt, only an option. So it won't add a "weird question" all the time.

ek9 commented 7 years ago

Thank you, I think this is good to mege

SBoudrias commented 7 years ago

Awesome thanks a lot!