ESLint for the project - Githubissues

jozefizso / generator-license

Yeoman Generator - License

MIT License

59 stars 20 forks source link

ESLint for the project #54

Closed ek9 closed 7 years ago

ek9 commented 7 years ago

As we are getting contributions, I would suggest to setup eslint as part of tests so the code is linted. It will help keeping the codebase clean and make sure the code does not contain anti-patterns.

Please let me know what you think, I could submit a PR for this.

ek9 commented 7 years ago

I have added an initial WIP PR for ESlintRC:

https://github.com/jozefizso/generator-license/pull/57

I'd like to point out that it depends on gulp PR in #56 ( the #57 has the #56 in it so I can demonstrate it). I have acitavted the config-xo- (https://github.com/sindresorhus/eslint-config-xo) as I believe this would be a decent config to use. Before I fix all the errors in the PR, could you confirm that we can use this linter?

ek9 commented 7 years ago

For a list of errors thrown by config-xo, see: https://travis-ci.org/jozefizso/generator-license/jobs/194125046