jozu-ai / kitops

Tools for easing the handoff between AI/ML and App/SRE teams.
https://KitOps.ml
Apache License 2.0
266 stars 26 forks source link

Your `tar` implementation has (potential) resources leaks #378

Open SamuelMarks opened 6 days ago

SamuelMarks commented 6 days ago

Specifically: https://github.com/jozu-ai/kitops/blob/b95676e/pkg/lib/harness/llm_payload_all.go#L138

Feel free to use my—Apache-2.0 OR MIT OR CC0—implementation: https://github.com/offscale/postgres-version-manager-go/blob/f14c61b/pvm/remote_fetch.go#L99-L167

gorkem commented 6 days ago

Thank you for reporting this. I see how it can go wrong. 😒 We do accept pull requests too 😄 Would you care to send one in?