Open ghost opened 11 years ago
Just wanted to ask if it is working - when you initially created the issue i thought maybe having a list of trinkets would be easier...but there even filtered for current content there are 134 use trinkets (only rare++ level 90 - http://www.wowhead.com/items=4.-4?filter=qu=3:4:5;minrl=90;cr=62;crs=1;crv=1) - so having a list won't be an easy option either.
Should work. It searches for the given strings.
The follow should work:
function jps.isManaRegTrinket(trinket) local result = parseTrinketText(trinket, {L["Use"], "spirit"}) or parseTrinketText(trinket, {L["Use"], "mana"}) return result end
function jps.trinketIncreasesHealth(trinket) return parseTrinketText(trinket, {L["Use"], "health"}) end
function jps.trinketAbsorbDmg(trinket) return parseTrinketText(trinket, {L["Use"], "absorb"}) end
function jps.isPVPInsignia(trinket) return parseTrinketText(trinket, {L["Use"], "Removes all movement impairing"}) end
the commented out "isDPSHPSTrinket" is untested. I want one function for DPS / HPS trinkets which could be used at any time of a fight to push dps/hps.
The only problem I discovered so far are trinkets with charges: Like "collect up to 5 charges of xyz" , "Use: release the charges of xyz as pew pew spell dealing xyz dmg for every hit"
parse trinkets use effect text so we don't waste them when cd is done (mana reg trinkets, insignia)