jp-ganis / JPS

Protected LUA DPS Addon
32 stars 46 forks source link

holy paladin tries to dispel enemy & run out of mana #382

Closed ghost closed 11 years ago

ghost commented 11 years ago

see title, holy pala tries to dispel an enemy again and again ,dont know if it is related to the last dispel function changes...

htordeux commented 11 years ago

I don't play a pala but reading wowpedia Cleanse removes all poison and all disease effects from a friendly target Sacred Cleansing removes magic effects

so jps.DispelMagicTarget() must be used with a magic dispell like sacred cleanse and not cleanse { "Cleanse",'jps.dispelActive() and jps.DispelMagicTarget() ~= nil', jps.DispelMagicTarget()

you're trying to dispell a magic effect , but in this case you must cast sacred claense

ghost commented 11 years ago

hmmm but it's a passive holy ability your learn @ lvl 20 . ( http://www.wowwiki.com/Sacred_Cleansing) So this should not be a problem because you still use "cleanse" to dispel.

The problem was more that the pala tried to dispel enemy units in target. Not friendly units with a debuff I cant dispel.

htordeux commented 11 years ago

dispel enemy? not possible the jps.DispelMagicTarget function loops on RaidStatus that contains only friends. so that fct return a friend name but if your target is an enemy i am pretty sure the pala want to dispel a magic debuff on a friend

ghost commented 11 years ago

hmm changed it the way it works in the restro druid.

htordeux commented 11 years ago

does it work better?