prot warrior broken :)

[ghost]

trying to fix this (want to level my warrior as tank :) )

current rotation: (any ideas?)

jps.registerStaticTable("WARRIOR","PROTECTION",function() -- Gocargo

local playerHealth = UnitHealth("player")/UnitHealthMax("player")
local targetHealth = UnitHealth("target")/UnitHealthMax("target")
local nRage = jps.buff("Berserker Rage","player")
local nPower = UnitPower("Player",1) -- Rage est PowerType 1
local stackSunder = jps.debuffStacks("Sunder Armor")

local spellTable = 
{
    { "Battle Shout" ,      not jps.buff("Battle Shout") and not jps.buff("Roar of Courage") and not jps.buff("Horn of Winter") and not jps.buff("Strength of earth totem") , "player" },
    { "Berserker Rage" ,    not nRage , "player" },
    { "Shield Wall" ,           playerHealth < 0.30 , "player" },
    { "Last Stand" ,            playerHealth < 0.40 , "player" },
    { "Impending Victory" ,playerHealth < 0.70 , "player" },
    { "Lifeblood" ,         playerHealth < 0.70 , "player" },
    --{ "Shield Block" ,            playerHealth < 0.80 , "player" },
    { "Shield Barrier" ,        playerHealth < 0.80 , "player" },
    --{ "Enraged Regeneration" ,    nRage and playerHealth < 0.80 , "player" }, 
    { "Pummel" ,                jps.shouldKick("target") , "target" },
    { "Spell Reflection" ,  UnitThreatSituation("player","target") == 3 and (UnitCastingInfo("target") or UnitChannelInfo("target")) , "target" },
    { "Shield Slam" ,       jps.buff("Sword and Board") , "target" },
    { "Thunder Clap" ,      jps.MultiTarget , "target" },
    { "Deadly Calm" ,       jps.MultiTarget and jps.UseCDs , "player" },
    { "Recklessness" ,      jps.UseCDs , "player" },
    { "Cleave" ,                nPower > 70 and jps.MultiTarget , "target" },   
    { "Devastate" ,         not jps.debuff("Sunder Armor","target") , "target" },
    { "Shield Slam" ,       },
    { "Revenge" ,               },
    { "Heroic Strike" ,     jps.buff("player", "Ultimatum") , "target" },
    { "Devastate" ,         stackSunder < 3 , "target" },
    { "Thunder Clap" ,      not jps.debuff("Weakend Blows", "target") },
    { "Heroic Throw" ,      },
    { "Battle Shout",           nPower < 100, "player" },
    { "Deadly Calm" ,       jps.UseCDs , "target" },
    { "Heroic Strike" ,     jps.buff("player", "Deadly Calm") , "target" },
    { "Heroic Strike" ,     nPower>90 , "target" },
    { "Impending Victory" , playerHealth < 0.90 , "target" },
    { "Devastate" ,         },

    { {"macro","/startattack"}, true, "target" },
}

local spell,target = parseSpellTable(spellTable)
return spell,target

end, "Default")

[kirk24788]

Hmm....what exactly is broken?

{ {"macro","/startattack"}, true, "target" },

seems useless...

Else you suffer from the same problem I did with the fury rotation....it only works wit hthe enless rage glyph and if you have much rage....won't work while leveling - at least it won't be effective... I just made a new which also works at lower levels...maybe something similar can be done for prot...

[ghost]

there was a lua error but didn't had time to copy it.

and:

  { {"macro","/startattack"}, true, "target" },

really didn't make seems since autoattack is there is a auto-attack in every class.

BTW: thx for the kanrethad rotation: did with itemlvl 510 without problems. Got some problems with the basic strategy but my raid warlock helped me in teamspeak :) Got him down after the 4-5 attempt.

[kirk24788]

your welcome ;)

I see a problem... you should use jps.registerRotation instead of jps.registerStaticTable - this is a function not a table ;)