search

jp-ganis / JPS

Protected LUA DPS Addon
32 stars 46 forks source link

Update Rotations #392

Closed htordeux closed 10 years ago

htordeux commented 10 years ago

There are so many changes add some code to work with firehack or a simple lua unlocker improve priest pve disc dropdown & tooltip are correct when multiples rotations ... perhaps test it before https://github.com/htordeux/JPS then merge or ignore ^_^

ghost commented 10 years ago

Thank you. I Test it later. But i Never will Understand why you Always make such Big pull requests. It is harder to test/Check them. Would be much easier with smaller commits. So i Need to merge it by Hand since I found stuff you removed and it was needed etc...Sorry for grammar, writing

ghost commented 10 years ago

Writing from my iPhone

htordeux commented 10 years ago

you're right and i've found a bug when the jpHistory written by kirk is not loaded i've added a hide/show fct but if the jpHistory is not loaded the fct hide/show is not loaded so ... erroe

close this comment for instance

htordeux commented 10 years ago

Iam using "source tree" to update github code and I don't know how to separate diff. update sorry this JPS have all rotations with differents update ( synapse...) I've updated the settings config and add a check for the jpHistory correct dropdown rotation & tooltip when you've multiples rotations update priest_disc_pve to keep mana ( tested in scenario) seems better then before