Rotation Error?

[Flubleah]

Hi, just wanted to say that I love JPS, when it works, it WORKS. But I get this error for no reason:

"Your Rotation has an error in: jps.shouldkick() --Interface\AddOns\JPS\jpconditionparser.lua:165: attempt to call a nil value Your Rotation has an error in: jps.shouldkick("focus") --Interface\AddOns\JPS\jpconditionparser.lua:165: attempt to call a nil value"

It doesn't matter if I have CD's/interrupts/multi/anything else enabled or disabled, I always get this error.

Note: I am using Noxxic 5.3 for Fury Warrior.

Thanks!

[htordeux]

add in function jps.shouldKick(unit) in modules/jpccinterrupt.lua if not jps.canDPS(unit) then return false end

function jps.shouldKick(unit) if not jps.canDPS(unit) then return false end

[spammatuamamma]

Hey guys, sorry for using this email list to get in touch, but what now that pg is closed?

Any workarounds?

On 16 Oct 2013, at 22:24, htordeux notifications@github.com wrote:

add in function jps.shouldKick(unit) in modules/jpccinterrupt.lua if not jps.canDPS(unit) then return false end

function jps.shouldKick(unit) if not jps.canDPS(unit) then return false end

— Reply to this email directly or view it on GitHub.

[Flubleah]

I still get the exact same error after adding that line...

[kirk24788]

@spammatuamamma See the issue #397 @Flubleah Did you update recently? And did you copy this error message? There is no function jps.shouldkick - it is jps.shouldKick - but the current fury rotation looks fine for me...

[Flubleah]

I didn't update, and I didn't copy the error message, I just wrote it out, probably left out the capitals. just checked and it is jps.shouldKick

I actually get the shouldkick error with any rotation that has interrupts in it. If I remove the interrupts it works fine. I have no idea why; However, the feral druid rotation is 100% ruined. It's got problems with just about every single line and I the more I remove it just makes the rotation not work at all... I'll copy the errors shortly...

ok so from the feral druid pve rotation I get this error: jpevents.lua:247 - Error Interface\AddOns\JPS\modules\jpauras.lua:240:bad argument #1 'tostring' (value expected) on OnUpdate function function: 278CAB38

back tracking I find 240 in jpauras.lua is part of the function "function jps.buffStacks(spell,unit)" and in the feral pve rotation the only skill that calls that is, "local cenarionStacks = jps.buffStacks(108381)" so if I remove that line I get an error on the shouldKick function line of the feral rotation 62. Removing that line (and the one below it because it's also a shouldkick function) gives me this error: jpevents.lua:247 - Error Interface\AddOns\JPS\Rotations\druid_feral_pve.lua:153: attempt to compare number with nil on OnUpdate function: 5B7F6518

line 153 is: { "Rake", not jps.MultiTarget and (energy >= rakeCost or clearcasting) and cenarionStacks > 0 and rakeDuration < 3 }, I don't know what of that is being compared to nil, probably the cenarionStacks, but I can't be sure. NOTE: this is not line 153 in the original because I deleted 6 lines of other stuff.

EDIT: Now I'm REALLY fucking confused. I just removed all traces of cenarionStacks and apparently JPS forgets that druid_feral_pve.lua is a rotation and it won't even show up... wtf.

[kirk24788]

Hmm....don't just remove lines - you will mess this up if you don't know what you're doing....in this case the feral pve rotation has so many errors because of this, that it won't be displayed.... Please remove your version of JPS and re-download it, then we'll start from scratch - but I'll be off for a few hours, guess I won't be bak till evening - but I'll take a look then...

[Flubleah]

Hey kirk I really appreciate your help! But I figured it out... The spell ID for cenarionStack is listed as (108381), I believe that ID doesn't exist right now so I replaced it with Dream of Cenarius, now I'm unsure if that's the actual stack buff OR if it's just the skill itself, which is 108373.

I can't confirm because I don't actually have a level 90 druid to test it; however, I believe with that new ID it should count stacks of dream of cenarius, but I'm not sure if the stacks have their own unique ID. (Is that even the real rotation??? I dunno). Either way, pre 90's the rotation works with the new ID.

Thanks for all your help guys, much appreciated, I'm also trying to learn how JPS is put together so this process is really helpful.

[ghost]

Hi,

going to help you & fix the bugs, but at the moment we need a PLUA unlocker first :(

[ghost]

there seems to be an error which kills a jps file. since event the function jps.shouldKick() ist not known when using JPS with FH

[ghost]

pushed an update, there was an syntax error