jp-ganis / JPS

Protected LUA DPS Addon
32 stars 46 forks source link

Feral Druid PVP #403

Open Flubleah opened 10 years ago

Flubleah commented 10 years ago

Hi guys,

Yet more problems... Feral Druid PVP. 1.) Zooms in 100% (I think this is setview(1), if so, why? I removed it and nothing changes I guess :S)

2.) Instead of doing a rotation just constantly shifts between cat form and druid form, doesn't do anything else (I removed anything with "cat form" in it and that solved the problem)

3.) Autocasts Berserk and King of the Jungle buffs when no one is around, even when out of combat, basically wastes the buff.

4.) Casts shred and mangle instead of ravage when king of the jungle is activated. It should be: shred and mangle when NOT behind target, then when behind target spam ravage.

I'm trying to fix it myself but I'm not familiar with lua, nor JPS. Trying though.

ghost commented 10 years ago

1) fixed in next release

2) can't reproduce it. do you uses the latest release? my lvl 80 feral doesn't have any problems dps a target dummy with the rotation and staying in cat form

3) can't cast something out of combat, since the rotation isn't executed.

4) hmm hard to check with a lvl 80 feral, but will look for some improvements ;)

Flubleah commented 10 years ago

2) I'm using most latest release. I've noticed JPS gets stuck when you actively shift forms, I've tried this with the guardian pve rotation as well. As for the feral PVP it just constantly switches in and out.

3) Ah sorry, I should have said it casts them when nothing is in range, like if you get shot by someone who is on the roof, it'll cast those buffs, kinda a waste.

4) My bad, realized the rotation says, "not" before the incarnation buff is active, so that portion does work.

ghost commented 10 years ago

2) could be that shift forms activate double like with burning rush @ warlocks. so you get into your cat form and leave instant :(

3) we could check if there is a unit in range for a specific spell. Would this be enough as a check for cooldowns?

4) we try to do the best :) any kind of feedback like this is always welcome ! :)

Flubleah commented 10 years ago

Thanks for all the help mdgit, I really appreciate you taking the time to try and help answer my questions.

Either way, I'm trying to work with JPS to make this rotation more functional, I've realized yes I could pair the buff with a "IsSpellInRange("rip",rangedTarget) == 1" it might only trigger when rip is within range; However, I don't know what the "rangedTarget" means in that function... I don't even know what the other possible conditions can replace rangedTarget. I believe that would fix it though.