search

jp-ganis / JPS

Protected LUA DPS Addon
32 stars 46 forks source link

Error in jpevents or jpcasting #424

Open Wellbond opened 9 years ago

Wellbond commented 9 years ago

When I join the game with LUA unlocked, my chat is now spammed with this:

jpevents.lua:247 ... nil value for OnCast (or something similar) ... jpcasting.lua:268 ... 34C17EE0.

This is spammed about 20 times a second, whether in combat or simply standing still. Disabling JPS halts the spam.

Could it be an issue with the specific unlocker being used?

Wellbond commented 9 years ago

The exact text of the error is (edit: while attempting to run the MM rotation and the SV rotation):

jpevents.lua:247 - Error Interface\AddOns\JPS\modules\jpcasting.lua:268: attempt to index local 'spellname' (a nil value) on OnUpdate function function: 3589D8B8

I am assuming that the last bit is a random memory location.

Wellbond commented 9 years ago

I get the same error in 32-bit and 64-bit, using two different tools, on both the MM and the SV rotations.

ghost commented 9 years ago

updated rotations/hunter.lua ...missed a file before..should be fine now :)

Wellbond commented 9 years ago

Is there a way to add another JPS toggle button and/or change an existing JPS toggle button?

For hunter, I would like to separate the Multi-Target toggle into two: Barrage and Multishot. Barrage should be used for 2 or more targets, but Multishot should only be used for 4+ or maybe even 5+ targets. One possibility is to use Multi-Target for Barrage, and take over Defensive for Multishot, but I would really like to maintain the functionality of both.

I know that PE has this feature, but I prefer JPS. In fact, my DPS is significantly better with JPS than with PE. Very strange.