jp-ganis / JPS

Protected LUA DPS Addon
32 stars 46 forks source link

Please add casting ability while riding Telaari Talbuk #425

Closed arch1mede closed 9 years ago

arch1mede commented 9 years ago

Currently when riding this mount that you get in Talador, you cannot cast and you have to dismount.

http://www.wowhead.com/spell=165803/telaari-talbuk

arch1mede commented 9 years ago

OK since this isn't being addressed, can someone at least tell me what I need to change to add if mounted start the rotation?

ghost commented 9 years ago

Hi,

sorry got not and in the next days, maybe week, zero time .

This should be in the jps.Cast function, jps.lua and in the line where you also find IsMounted() ... need here another check for " jps.buff("Telaari Talbuk") or something like that.

arch1mede commented 9 years ago

This is the only line with what you are describing:

-- STOP Combat
if (IsMounted() == true and jps.getConfigVal("dismount in combat") == 0) or UnitIsDeadOrGhost("player")==1 or jps.buff(L["Drink"],"player") then return end

Dont think I want it under stop combat?

But if it does need to go under it would it be:

-- STOP Combat
if (IsMounted() == true and jps.getConfigVal("dismount in combat") == 0) or UnitIsDeadOrGhost("player")==1 or jps.buff(L["Drink"],"player", "Telaari Talbuk") then return end

OR

-- STOP Combat if (IsMounted() == true and jps.getConfigVal("dismount in combat") == 0) or UnitIsDeadOrGhost("player")==1 or jps.buff(L["Drink"],"player") or jps.buff("Telaari Talbuk")then return end

ghost commented 9 years ago

the comment is missleading...

the if should be than like this:

-- STOP Combat
if ((IsMounted() == true and not jps.buff("Telaari Talbuk")) and jps.getConfigVal("dismount in combat") == 0 ) or UnitIsDeadOrGhost("player")==1 or jps.buff(L["Drink"],"player") then return end
arch1mede commented 9 years ago

OK thanks I will try that and let you know.

arch1mede commented 9 years ago

Works great, thank you. Closing