search

jp-ganis / JPS

Protected LUA DPS Addon
32 stars 46 forks source link

Subtlety Rogue error #435

Open blackcardi opened 9 years ago

blackcardi commented 9 years ago

If someone is still working on JPS thanks for the addon, I love it and have used it off and on since Cataclysm so Thanks to you guys.

Over the last couple months I have done my best to fix some of these but I just end of causing more errors because of my ignorance.

jpevents.lua:247 - Error Interface\AddOns\JPS\modules\jpauras.lua:49: bad argument #1 to 'tostring' (value expected) on OnUpdate function function: 000000003C7ABDE8

kirk24788 commented 9 years ago

Hmm...have you tried to check out a new (clean) JPS version?

blackcardi commented 9 years ago

That is using the JPS-master downloaded about 4 weeks ago. I have not tried JPS-1.3.2. I will do that this afternoon.

blackcardi commented 9 years ago

I see that there have been many changes since 1.3.2 so I will assume that the JPS-master version I have right now is the new clean version.

Assassination is the only Rogue rotation I have been able to make work since all I had to do was take out Slice and Dice as it is now passive for Assassination.

Is there a forum to share profiles and changes like there used to be on the PG forums?

kirk24788 commented 9 years ago

Hmm...nope 1.3.2 is an old release,the current master should work...at least most of it. Sadly PCMD has been the only one who has committed within the last 5 months...and his account seems to be deleted with the last commit from february. Some of the rotations have errors and currently there is nobody left who seems to care about the issues and pull requests (there are a few by @shikulja)

There is a forum - see issue #397 - but there isn't much talk and no current rotations.

You can either use ProbablyEngine (which is actively developed - see OwnedCore for rotations) or keep using JPS but write your own rotations.

I currently waste most of my time developing my bot...but maybe I'll try to rewrite JPS from scratch, I'm not that happy with PE Rotations....or I'll try to convert my warlock rotation to PE...

blackcardi commented 9 years ago

I also dislike PE. There is at least one JPS rotation working for every class though some do take quite a bit of cleaning up. All three specs for hunter and DK work great out of the box iirc.

I will post some other issues. If you are able to help, that's great. If not, no big deal.

While I will probably not partake in your bot that you are creating since I had all my accounts banned two years ago for running a gold selling operation, I would most definitely donate $$$ for a rewriting of JPS.

jp-ganis commented 9 years ago

I'm still kinda working on JPS. I have a sick moonkin rotation atm that does multidotting, aoe detection, and the ability to cast spells without facing the target. I might upload it? But I dunno who's still using JPS or moonkin :P

blackcardi commented 9 years ago

In my opinion JPS is far superior to PE. I think a lot of PE users would use JPS if they knew about JPS.

I leveled one of my Druids to 90 as moonkin then switched to feral. I thought the stock moonkin rotation worked pretty good. But I would try anything that was uploaded if you wanted to do it.

kirk24788 commented 9 years ago

Well I'm using JPS...but mostly on Warlock...but your moon kin rotation would be interesting. I'm using my custom WarlockRotation... Back when PE was started it was superior in memory consumption, but couldn't compete with JPS regarding max DPS...it just wouldn't work as good as JPS, don't know how good it is now - there has been a lot of work on PE, but I don't like the rotations...too limiting if you want to create a rotation which can rank in the top 20 on world of logs...

But JPS requires a major refactoring, maybe a little change in the condition statements...so simcraft rotations can be easily imported...

arch1mede commented 9 years ago

Well I can tell you from experience that PE pales in comparison to JPS which makes me sad that JPS is no longer being worked on. I have a SP that need a shadow rotation BADLY but its broke, Pally that has 0 rotations because I think something is missing, Rogue that just sucks for rotations....so far EL Shaman is decent and Hunters are really good.

I really wish I wasn't coding challenged otherwise I would start fixing some of these rotation myself.

kirk24788 commented 9 years ago

Well...I used the last few days for a complete refactoring of the JPS code. Well, actually I completely rewrote half of the JPS core and took the other half from JPS or removed it. Currently there is no healing support and only one rotation. I still have to write a script for converting SimCraft rotations, then I'll have to add healing.

blackcardi commented 9 years ago

Wow that's great! I wish there were something I could do to help out. I have no idea how much work that took but it sounds like a lot.

arch1mede commented 9 years ago

Kirk: Are you going to fork your build? If so please let us know what and where its going to be located;

kirk24788 commented 9 years ago

It will be located at https://github.com/kirk24788/KPS - currently it is only available in my private Git Repository. There are still a few TODO'S in my code, and I have to do a performance analysis. Currently there is only a Destruction Lock Rotation (hand-made) and Death Knight Rotations (auto-convert from SimCraft). I won't be online the next week, but maybe I'll have time to do some more coding. I'll do the push tho GitLab within the next 2 weeks (as soon as I switch to KPS from JPS for raiding)