Default values for ingresses - update

jp-gouin / helm-openldap

Helm chart of Openldap in High availability with multi-master replication and PhpLdapAdmin and Ltb-Passwd

Apache License 2.0

199 stars 118 forks source link

Default values for ingresses - update #110

Closed mrachuta closed 1 year ago

mrachuta commented 1 year ago

What this PR does / why we need it:

Additional (popular) default values added to both ingresses to make it more user-friendly. ingressClassname reduce chance to face the issues with #404 error after deployment (especially for ingress-nginx users).

Pre-submission checklist:

[x] Did you explain what problem does this PR solve? Or what new features have been added?
[x] Have you updated the readme?
[x] Is this PR backward compatible?

Tests

Tested on k8s 1.27.0

jp-gouin commented 1 year ago

Thank you @mrachuta for your PR

Can you update the Readme as well and add new arguments in the value table ?

Many thanks

mrachuta commented 1 year ago

Thank you @mrachuta for your PR

Can you update the Readme as well and add new arguments in the value table ?

Many thanks

Hello @jp-gouin. I've did update in README files for sub-charts and their values.yaml. I also added small annotation to general README.