search

jp-gouin / helm-openldap

Helm chart of Openldap in High availability with multi-master replication and PhpLdapAdmin and Ltb-Passwd
Apache License 2.0
183 stars 115 forks source link

Copy tls.crt to ca.crt always unless ca.crt exists #117

Closed pschichtel closed 9 months ago

pschichtel commented 11 months ago

Previously the init container only copied tls.crt to ca.crt after generating a new certificate. When using cert-manager with an ACME issuer to generate a certificate, the resulting secret will also not have a ca.crt. When doing the copy like this, both cases would be covered without impacting other cases.

pschichtel commented 11 months ago

This in combination with reloader allows me to use letsencrypt via cert-manager.

pschichtel commented 11 months ago

@jp-gouin tagging you just in case your notification setup is similar to mine.

jp-gouin commented 11 months ago

Hi @pschichtel

Thanks for the PR!

pschichtel commented 11 months ago

looks like CI is broken due to a broken ubuntu mirror

pschichtel commented 11 months ago

@jp-gouin https://github.com/jp-gouin/helm-openldap/actions/runs/5709478492/job/15554209769#step:8:19

jp-gouin commented 11 months ago

Yeah looks like it , please bear with me , I'm a bit off at the moment but I'll look into it end of month

lwj5 commented 10 months ago

@jp-gouin you can take a look at a workflow I made. Looking to get this feature as well

https://github.com/invoiceninja/dockerfiles/blob/master/.github/workflows/test-charts.yaml

These are good to have:

You can extend install-chart with your tests