Allow overriding global.server value

jp-gouin / helm-openldap

Helm chart of Openldap in High availability with multi-master replication and PhpLdapAdmin and Ltb-Passwd

Apache License 2.0

183 stars 115 forks source link

Allow overriding global.server value #126

Closed antoncuranz closed 7 months ago

antoncuranz commented 9 months ago

What this PR does / why we need it:

I am using this helm chart with a custom nameOverride, which results in the service name not matching .Release.Name. Thus, phpldapadmin is not able to connect to openldap. It would be nice to be able to override the value of global.server which is currently used by phpldapadmin and ltb.

Pre-submission checklist:

[x] Did you explain what problem does this PR solve? Or what new features have been added?
[x] Have you updated the readme?
[x] Is this PR backward compatible? If it is not backward compatible, please discuss open a ticket first

jp-gouin commented 9 months ago

Hi @ant0ncuranz thanks for the PR

Can you instead of adding a new variable into global use a nameOverride variable at phpLdapAdmin and ltbpasswd level ?

antoncuranz commented 9 months ago

Hi @jp-gouin, As far as I understood, the nameOverride variable of openldap is unfortunately not accessible in phpLdapAdmin and ltbpasswd, as it is not global.

For context, I am using this in a Helm chart named authentication and am using nameOverride: "openldap" to achieve the following naming of the services:

authentication-openldap
authentication-phpldapadmin

But phpLdapAdmin is still pointing at authentication.(namespace) instead of authentication-openldap.(namespace).

stale[bot] commented 7 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.