fix: Allow IPv6 on ltb-passwd

jp-gouin / helm-openldap

Helm chart of Openldap in High availability with multi-master replication and PhpLdapAdmin and Ltb-Passwd

Apache License 2.0

183 stars 115 forks source link

fix: Allow IPv6 on ltb-passwd #127

Open SuperQ opened 9 months ago

SuperQ commented 9 months ago

What this PR does / why we need it:

Listen on both IPv4 and IPv6 in the ltb-passwd to fix health probes on dual-stack clusters.
Include upstream chart env in main values.yaml.

https://github.com/tiredofit/docker-self-service-password/issues/66

Pre-submission checklist:

[x] Did you explain what problem does this PR solve? Or what new features have been added?
[ ] Have you updated the readme?
[x] Is this PR backward compatible? If it is not backward compatible, please discuss open a ticket first

stale[bot] commented 7 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

SuperQ commented 7 months ago

Not stale, just need review by @jp-gouin

stale[bot] commented 5 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

SuperQ commented 5 months ago

Still not stale

stale[bot] commented 3 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

SuperQ commented 3 months ago

Still waiting

stale[bot] commented 1 month ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

SuperQ commented 1 month ago

Still waiting

jp-gouin commented 1 month ago

Hi @SuperQ , I'm not sure your issue need a fix in the values as the chart already allows you specifying ltb-passwd.env

Maybe would make more sense to add the info in the readme ?

I know it's been a while , so feel free to close the PR and I'll include the variable in the readme in the next update

SuperQ commented 1 month ago

I don't really mind how it is changed, but I think the defaults for this chart should work correctly with dual stack by default.