jp-gouin / helm-openldap

Helm chart of Openldap in High availability with multi-master replication and PhpLdapAdmin and Ltb-Passwd
Apache License 2.0
198 stars 118 forks source link

Allow to disable port on services. #155

Closed guillomep closed 4 months ago

guillomep commented 6 months ago

What this PR does / why we need it:

When using service as load balancer, if we setup ldap to be on secure port only we don't want to expose the insecure port. Currently there is no way to do that.

With this modification, users can enable or disable exposition of insecure or secure port on the service.

Default values keep the current behaviour.

Pre-submission checklist:

jp-gouin commented 5 months ago

Can you add a test where you disable the ldap port and test the replication (writing a entry and reading it) ? You can check on existing tests

guillomep commented 5 months ago

@jp-gouin Okay I think I manage to create tests

Is that okay for you ?