jp-gouin / helm-openldap

Helm chart of Openldap in High availability with multi-master replication and PhpLdapAdmin and Ltb-Passwd
Apache License 2.0
198 stars 118 forks source link

support customSchemaFiles and extraSchemaFiles options #167

Closed wkloucek closed 2 months ago

wkloucek commented 4 months ago

What this PR does / why we need it:

The current customSchemaFiles option does a schema import via LDAP_EXTRA_SCHEMAS. I renamed this current behavior to extraSchemaFiles. It's done via ldapadd while slapd is running.

I added a new customSchemaFiles option that imports schemas via LDAP_CUSTOM_SCHEMA_DIR. It's done via slapadd while slapd is stopped.

Since the new customSchemaFiles option does not support all schemas that could be set via the current customSchemaFiles option, this change is not backwards compatible. The migration should be easy though because one just needs to use the extraSchemaFiles option instead.

Related issues:

Pre-submission checklist:

wkloucek commented 3 months ago

@jp-gouin After digging into this PR, I think we don't really benefit from another schema import besides the one we currently have, especially since the import order was fixed in #161. If you have a reasoning for supporting both mechanisms, I'm happy to continue this PR. Otherwise I'll close it.