jp-gouin / helm-openldap

Helm chart of Openldap in High availability with multi-master replication and PhpLdapAdmin and Ltb-Passwd
Apache License 2.0
183 stars 115 forks source link

Added port customization to liveness probe for the statefulset template #90

Closed thekoma closed 1 year ago

thekoma commented 1 year ago

What this PR does / why we need it:

Added port customization to liveness probe for the statefulset template Without this using a custom port will fail if ports are not 1389 and 1636

Pre-submission checklist:

jp-gouin commented 1 year ago

Hi @thekoma , Thanks for the PR.

did you try with the latest version of the chart because

global:
  ldapPort: 389
  sslLdapPort: 636

Set ports to something different than containerPort which are only used internally (non privileged port, replication port and probe) Liveness and Readiness probe are working in this configuration.

thekoma commented 1 year ago

I've copied the values.yaml in toto and it didn't work withotu changing those values. Also an ss -tnlp showed me that the listening port for the container are 389 and 636.

Best Regards,

Andrea Cervesato

Phone: Mail: @.***


This email and its attachments might be confidential and are only for use of intended recipient. If you are not the intended recipient, please notify us immediately by sending back the email and delete it from your machine. You are not allowed to disseminate nor to copy the content of the email if you are not the intended recipient.

On Thu, 19 Jan 2023 at 10:29, jpgouin @.***> wrote:

Hi @thekoma https://github.com/thekoma , Thanks for the PR.

did you try with the latest version of the chart because

global: ldapPort: 389 sslLdapPort: 636

Set ports to something different than containerPort which are only used internally (non privileged port, replication port and probe) Liveness and Readiness probe are working in this configuration.

— Reply to this email directly, view it on GitHub https://github.com/jp-gouin/helm-openldap/pull/90#issuecomment-1396678416, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAB4LATNKHZPS7D3FDH7X5TWTECQDANCNFSM6AAAAAAT7U2T3M . You are receiving this because you were mentioned.Message ID: @.***>

jp-gouin commented 1 year ago

Can you copy the full values you are using ? And the chart.yaml file as well please

thekoma commented 1 year ago

Sure: https://gist.github.com/thekoma/a7d3d84bb1e3e249d6b3daa2aad4be3e

jp-gouin commented 1 year ago

Thanks , you are using the old configuration (values from 3.x.x chart version ) Now the chart is in v4.x.x and the values has changed along the openldap image

image:
      pullPolicy: Always
      repository: osixia/openldap
      tag: 1.5.0

is now

image:
  # From repository https://github.com/osixia/docker-openldap
  repository: bitnami/openldap
  tag: 2.6.3

If you want to upgrade to the latest version , I suggest you deploy the newer version, dump all your ldap tree from the previous version. Import them in the newer and check everything is fine before removing the older release