jp-gouin / helm-openldap

Helm chart of Openldap in High availability with multi-master replication and PhpLdapAdmin and Ltb-Passwd
Apache License 2.0
199 stars 118 forks source link

Update values.yaml (Fix synchronization of config db) #92

Closed wotsyula closed 1 year ago

wotsyula commented 1 year ago

What this PR does / why we need it:

Have default config user match replication config user: https://github.com/jp-gouin/helm-openldap/blob/8efc199864ae5833edbe64fba701d3e3dddb474a/templates/_helpers.tpl#L78-L83

This allows config database to also be synced between masters.

Pre-submission checklist:

wotsyula commented 1 year ago

This is a quick fix. A more permanent solution would be to add Values.env.LDAP_CONFIG_ADMIN_USERNAME to binddn below: https://github.com/jp-gouin/helm-openldap/blob/8efc199864ae5833edbe64fba701d3e3dddb474a/templates/_helpers.tpl#L78-L83

jp-gouin commented 1 year ago

Thanks @wotsyula for the PR ! I'm working on PR #91 right now which correct that issue

I like your suggestion, I'll add it the the helper directly !

jp-gouin commented 1 year ago

Corrected in latest release v4.1.0