search

jp-powers / fan-control

IPMI Fan Control via fan curves for TrueNAS Core, Proxmox, and pfSense
52 stars 8 forks source link

Installer changes: Vi, not nano. Do not overwrite existing config. #12

Closed miggland closed 1 month ago

miggland commented 1 month ago

This is definitely not personal preference, but nano is not installed on pfSense by default, so the command fails as written.

Vi is present.

miggland commented 1 month ago

I am not sure that not overwriting the config.ini is what you intended with the generator script, but IMHO there should be some check (for those who have not updated the generator script, or if the generator script is updated by doing a pull)