search

jp-powers / fan-control

IPMI Fan Control via fan curves for TrueNAS Core, Proxmox, and pfSense
52 stars 8 forks source link

fix fan_control_linked with CPU control_focus #5

Closed aimestereo closed 1 year ago

aimestereo commented 1 year ago

Hi there!

Noticed that if control_focus == "CPU" then code is not checking fan_control_linked and assumes separate fan zone layout.

Unnecessary rumbling: I have PERC H330 mini Raid controller in my R630 and it doesn't provide disks SMART data (that's how smartctl gets its metrics), so I currently can't monitor both CPU and HDD.

jp-powers commented 1 year ago

Hey @aimestereo! Thanks for the PR. I'm in the second week of a new job so don't quite have the same free time as I used to, so I'll try to review this sometime this week. Did a quick spot check of the PR and I think I have a different idea to make it act as intended, so hopefully this weekend at least I can get the changes in place.

jp-powers commented 1 year ago

I adjusted the changes to match the rest of the script's methodology with PR6. It should effectively be the same, it just matches the rest of the script so when I (eventually, hopefully) get around to fixing the nested mess it'll be easier to match up the needs.

I'll wait to close this PR until you have a chance to try v2.6, let me know how it goes.

aimestereo commented 1 year ago

np, I saw https://github.com/jp-powers/fan-control/pull/6 P.S. I can't test it as I went with my version and I pile changes on top of it