jp-williams / evolutionchamber

Automatically exported from code.google.com/p/evolutionchamber
0 stars 0 forks source link

integral division result cast to double or float #217

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Bug: integral division result cast to double or float
Pattern id: ICAST_IDIV_CAST_TO_DOUBLE, type: ICAST, category: STYLE

This code casts the result of an integral division (e.g., int or long division) 
operation to double or float. Doing division on integers truncates the result 
to the integer value closest to zero. The fact that the result was cast to 
double suggests that this precision should have been retained. What was 
probably meant was to cast one or both of the operands to double before 
performing the division. Here is an example: 

int x = 2;
int y = 5;
// Wrong: yields result 0.0
double value1 =  x / y;

// Right: yields result 0.4
double value2 =  x / (double) y;

Original issue reported on code.google.com by netpr...@gmail.com on 20 Jul 2011 at 8:30

GoogleCodeExporter commented 8 years ago
This issue was closed by revision r297.

Original comment by netpr...@gmail.com on 20 Jul 2011 at 8:31