search

jp112sdl / Beispiel_AskSinPP

88 stars 36 forks source link

Fixed the calls of the Si7021 sensor library #43

Closed skaringa closed 3 years ago

skaringa commented 3 years ago

The code for the SI7021 variant of the HM-WDS40-TH example didn't work for me with the library mentioned in the code: jayjayuk/Si7021-Humidity-And-Temperature-Sensor-Library. Maybe it was developed against an older version of the lib? I have fixed the sketch and successfully build a temp/hygro sensor with it. Anyway, many thanks for providing AskSinPP and the example code for several sensors!

jp112sdl commented 3 years ago

didn't work

...means what?

The sketch uses the <sensors/Si7021.h> class from the asksinpp lib. https://github.com/pa-pa/AskSinPP/blob/master/sensors/Si7021.h which uses https://github.com/pa-pa/AskSinPP/blob/91fadb267c3a71b75b500adf271e48bf4d408003/sensors/Si7021.h#L15

Compiling works fine.

skaringa commented 3 years ago

I used the library mentioned in the code (line 12): https://github.com/jayjayuk/Si7021-Humidity-And-Temperature-Sensor-Library

And the sketch doesn't compile with the actual master branch of that library.

I never heard of https://github.com/pa-pa/AskSinPP/blob/91fadb267c3a71b75b500adf271e48bf4d408003/sensors/Si7021.h#L15

Maybe you should put a comment into the example to use https://github.com/pa-pa/AskSinPP/blob/91fadb267c3a71b75b500adf271e48bf4d408003/sensors/Si7021.h#L15 instead of https://github.com/jayjayuk/Si7021-Humidity-And-Temperature-Sensor-Library.

jp112sdl commented 3 years ago

I used the library mentioned in the code (line 12):

Line 12 ? It is line 17: https://github.com/jp112sdl/Beispiel_AskSinPP/blob/be63b0f1f44107bb7e00fbc28fd968f6b6108aca/examples/HM-WDS40-TH-I-SI7021/HM-WDS40-TH-I-SI7021.ino#L17

And it is the same link as mentioned in https://github.com/pa-pa/AskSinPP/blob/91fadb267c3a71b75b500adf271e48bf4d408003/sensors/Si7021.h#L15

The sketch compiles daily by GH Actions https://github.com/pa-pa/AskSinPP/runs/3211645935?check_suite_focus=true using the latest Si7021-Library.

skaringa commented 3 years ago

I used the library mentioned in the code (line 12): https://github.com/jayjayuk/Si7021-Humidity-And-Temperature-Sensor-Library

And the sketch doesn't compile with the actual master branch of that library.

I never heard of https://github.com/pa-pa/AskSinPP/blob/91fadb267c3a71b75b500adf271e48bf4d408003/sensors/Si7021.h#L15

Maybe you should put a comment into the example to use https://github.com/pa-pa/AskSinPP/blob/91fadb267c3a71b75b500adf271e48bf4d408003/sensors/Si7021.h#L15 instead of https://github.com/jayjayuk/Si7021-Humidity-And-Temperature-Sensor-Library.

skaringa commented 3 years ago

Now I see. You are using your own header file Si7021.h which is not identical to Si7021.h from jayjayuk/Si7021-Humidity-And-Temperature-Sensor-Library. Because both header files have the same name I was lead into the wrong direction.