search

jp1995 / kappa-launcher

Twitch launcher using Rofi
MIT License
27 stars 4 forks source link

latest rofi versions dont show the proper kpl window initially #16

Closed jasondaigo closed 1 year ago

jasondaigo commented 1 year ago

it worked up to version 1.7.3 (stil works if i roll back). But 1.7.4 and 1.7.5 shows this initial window now. telling me rofi doesnt know what window to show. i can just hit escape and it still works after that. is there a workaround maybe. ? for more convenience :-) https://imgur.com/a/lBy3pqV

jp1995 commented 1 year ago

Interesting, I can't seem to reproduce this with rofi 1.7.5.

Every time rofi is called in the script it's in dmenu mode so I'm unsure why it would show that.

Is there anything interesting in the output when you run kpl in the terminal?

jasondaigo commented 1 year ago

no only the standard stuff

Configuration file found, proceeding
json file successfully populated

i also created a new config (kpl & rofi itself), just in case. but thats not changing anything

jp1995 commented 1 year ago

Took a bit of digging but I figured it out. The issue is in the fontname and fontsize function, which call rofi -dump-xresources, which has been deprecated.

Temporary workaround is to declare a font (and font size) in either kpl config or rofi config as this way the function never hits the deprecated call.

I'll fix it in a couple days and probably just remove that part of the functions.

vtuhes commented 1 year ago

Just commented out the line in /usr/bin/kpl to avoid seeing the error Pepechill https://i.imgur.com/R6xfLfK.png.

jp1995 commented 1 year ago

Only took 9 months... should be fixed now :)