Don't default to best on watch now if streamlink has a quality order set

the1ts commented 4 years ago

Streamlink has a nice config option (not set by default) to list preferred stream qualities in order (default-stream), since the user has made the decision to set that, lets respect that decision.

If streamlink config item exists, run streamlink allowing it to decide quality if Watch now is picked, i.e. QUALITY="".
If streamlink item doesn't exist Watch now still defaults to best
User can still pick quality in Choose quality.

jp1995 commented 4 years ago

Can you give me an example of that config file so I can test this?

the1ts commented 4 years ago

Sure, the default location is the similar to kpl, so ends up usually in ~/.config/streamlink/config. The below means I can watch side by side 720p streams on a 1440p monitor. Streamlink picks the first in common with the those available but defaults to best if none available. Streamlink also overrides these values if told to on the command line as kappa-launcher does now and will do after the patch.

default-stream=720p60,720p,best player=mpv --cache 8192 & player-no-close player-passthrough=hls hls-segment-threads=10 twitch-oauth-token=EnterYours

jp1995 commented 4 years ago

Ah, that's neat. I just wanna make sure I don't have any misunderstandings about how any part of the script works.

jp1995 / kappa-launcher

Don't default to best on watch now if streamlink has a quality order set #6