search

jp7677 / dxvk-nvapi

Alternative NVAPI implementation on top of DXVK.
MIT License
353 stars 32 forks source link

Add a few OpacityMicromap-related stubs #119

Closed Saancreed closed 1 year ago

Saancreed commented 1 year ago

Should fix https://github.com/HansKristian-Work/vkd3d-proton/issues/1507 on Nvidia GPUs which is actually caused by dxvk-nvapi not implementing those 3 functions.

I'm not sure if that's the correct place for a helper like ConvertBuildRaytracingAccelerationStructureInputs but dumping it into NvapiD3d12Device doesn't feel right either.

jp7677 commented 1 year ago

I'm not sure if that's the correct place for a helper like ConvertBuildRaytracingAccelerationStructureInputs but dumping it into NvapiD3d12Device doesn't feel right either.

We could introduce a new util_ for that method, but no strong feelings for that or leave it here like you did. NvapiD3d12Device indeed doesn't feel like the right place.

Saancreed commented 1 year ago

Feel free to move that helper around as you see fit, especially if you decide to test it separately from the functions calling it.

Also, nits should be resolved now.