search

jp7677 / dxvk-nvapi

Alternative NVAPI implementation on top of DXVK.
MIT License
353 stars 32 forks source link

Implement NVAPI_GetLogicalGPUFromPhysicalGPU #122

Closed nvetillison closed 1 year ago

nvetillison commented 1 year ago

Implement NVAPI_GetLogicalGPUFromPhysicalGPU as the inverse of NVAPI_GetPhysicalGPUsFromLogicalGPU.

jp7677 commented 1 year ago

Thanks for the contribution. Could you please state your motivation behind this PR and what is solves in the real world?

nvetillison commented 1 year ago

Sure! The function NvAPI_GPU_GetAdapterIdFromPhysicalGpu was deprecated with NvAPI release 520, and the suggested alternative is to replace it with a call to NvAPI_GetLogicalGPUFromPhysicalGPU, and then use NvAPI_GPU_GetLogicalGpuInfo to get the adapter ID.

This change is proposed in the interest of supporting applications that use the new code path.

jp7677 commented 1 year ago

Do you know any applications/titles that already use that path?

liam-middlebrook commented 1 year ago

Do you know any applications/titles that already use that path?

We're switching DLSS over to use the new path. I'm not aware of any titles that are currently using the new path that could be used for testing on your side though.

jp7677 commented 1 year ago

@nvetillison sry, I didn't recognized the first two letters in your github name ;) Could you please prefix the commit message with nvapi:? Otherwise, LGTM!

jp7677 commented 1 year ago

Landed on master and thanks a lot for already taking this project into account!

oscarbg commented 1 year ago

@liam-middlebrook curious even latest DLSS 3.1.10 SDK windows demo (https://github.com/NVIDIA/DLSS/releases/tag/v3.1.10) isn't using it, for testing? anyway hope NV is working on DLSSG (frame generation) Wine support, and can get some cool anouncement soon (later this year?)