search

jpadilla / django-rest-framework-jwt

JSON Web Token Authentication support for Django REST Framework
http://jpadilla.github.io/django-rest-framework-jwt/
MIT License
3.19k stars 649 forks source link

Add python 3.6 support. #306

Closed jrocketfingers closed 7 years ago

jrocketfingers commented 7 years ago

Covers #305.

Sidenote: There are some errors with DRF 3.0 across all python versions in my environment, has anyone had that happen?

jrocketfingers commented 7 years ago

Ooook, so there's a problem with travis, you can either have a 3.5 or a 3.6 environment. But then again I didn't work with it extensively.

The good news is that the tests pass with 3.6, but please don't merge until we figure out how to set up travis (I'll check DRF again).

carltongibson commented 7 years ago

This was the DRF PR that added Python 3.6: https://github.com/tomchristie/django-rest-framework/pull/4811 — you basically have to specifically include the extra environments.

Personally I don't like this: you end up duplicating the tox config in the travis config, so every time you make a change you need to make it in both places.

For https://github.com/carltongibson/django-filter/pull/631 I'm looking at using docker with the required Python versions pre-installed so I can just use tox (as we have been doing until hitting this problem). It's a little bit slower currently, because the caching needs tweaking, but it works. You might want to look at it.

jheld commented 7 years ago

Any updates here?

jrocketfingers commented 7 years ago

Been way to far from this recently. Won't have time to dive back in for a couple of weeks, feel free to take over.

blueyed commented 7 years ago

For reference, tox-travis might be an option: https://github.com/carltongibson/django-filter/pull/651/files.

blueyed commented 7 years ago

Thanks, continued in https://github.com/GetBlimp/django-rest-framework-jwt/pull/371.