Optimization of DB queries when decoding token with per user secret.

jpadilla / django-rest-framework-jwt

JSON Web Token Authentication support for Django REST Framework

MIT License

3.19k stars 652 forks source link

Open jacoor opened 7 years ago

jacoor commented 7 years ago

When using token secret on user, DB is called twice to decode token:

once by id to get secret
second time by natural key in "authenticate_credentials" Because of two different keys used to call DB this database query was hard to cache. The code was changed to use "get_by_natural_key" in both cases.

Other improvements:

jacoor commented 7 years ago

Hello @jpadilla, you probably remember me from creating https://github.com/GetBlimp/django-rest-framework-jwt/pull/310. Now I added a little optimisation we could use on our projects soon. Could you release this in the near future, pretty please?

Thank you!