search

jpadilla / django-rest-framework-jwt

JSON Web Token Authentication support for Django REST Framework
http://jpadilla.github.io/django-rest-framework-jwt/
MIT License
3.19k stars 650 forks source link

Django 2.0 #433

Open ronaldlangeveld opened 6 years ago

ronaldlangeveld commented 6 years ago

Any plans for Django 2.0 support?

kamilgregorczyk commented 6 years ago

It seems to work for me, do you have any problems?

joeyworld commented 6 years ago

If it is compatible with django 2.0, wouldn't be better if the docs could be updated? - #435 #436

ronaldlangeveld commented 6 years ago

I got it working. :D Thanks guys!

budiardy commented 6 years ago

It doesn't work well with django 2.0. The issue is: failed to overwrite 'JWT_RESPONSE_PAYLOAD_HANDLER' setting. the default is: 'JWT_RESPONSE_PAYLOAD_HANDLER': 'rest_framework_jwt.utils.jwt_response_payload_handler', want to become: 'JWT_RESPONSE_PAYLOAD_HANDLER': 'jwt_response_payload_handler', i put the "def jwt_response_payload_handler" in the same page in the django settings file. I guess it because the different version of Django

jadhavmanoj commented 5 years ago

Any update on support django 2.x? I am now evaluating which JWT auth package use for python 3.x & Django 2.x.

krdeepak commented 5 years ago

Same here. I tried https://github.com/davesque/django-rest-framework-simplejwt, but this seems to be more widely adopted. Is someone working on django 2.0 official support?

jadhavmanoj commented 5 years ago

@krdeepak I used in Django 2.x. I don't see any issue. It works good.

stunaz commented 5 years ago

@jadhavmanoj but the tests are not against Django 2.x in this repo

jadhavmanoj commented 5 years ago

@stunaz true. currently, I am writing test cases for Django 2.1 support. I will send PR once I finished.

jadhavmanoj commented 5 years ago

@stunaz Please check PR #479 All test cases executed except for python version 3.3. tox has some issue for python version 3.3.

stunaz commented 5 years ago

cool @jadhavmanoj . Now, good luck to get it merged. this project is abandoned, hasnt get updated for years ... see https://github.com/GetBlimp/django-rest-framework-jwt/issues/449