Open dipasqualew opened 6 years ago
Merging #443 into master will decrease coverage by
0.3%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #443 +/- ##
==========================================
- Coverage 90.67% 90.36% -0.31%
==========================================
Files 14 12 -2
Lines 847 820 -27
Branches 29 29
==========================================
- Hits 768 741 -27
Misses 66 66
Partials 13 13
Flag | Coverage Δ | |
---|---|---|
#codecov | 90.36% <100%> (-0.31%) |
:arrow_down: |
#dj110 | 87.07% <100%> (-0.42%) |
:arrow_down: |
#dj111 | 87.07% <100%> (-0.42%) |
:arrow_down: |
#dj18 | 89.51% <100%> (-0.34%) |
:arrow_down: |
#dj19 | 89.51% <100%> (-0.34%) |
:arrow_down: |
#dj20 | 89.14% <100%> (?) |
|
#drf31 | 89.51% <100%> (-0.34%) |
:arrow_down: |
#drf32 | 89.51% <100%> (-0.34%) |
:arrow_down: |
#drf33 | 89.51% <100%> (-0.34%) |
:arrow_down: |
#drf34 | 90.36% <100%> (-0.31%) |
:arrow_down: |
#drf35 | 90% <100%> (-0.32%) |
:arrow_down: |
#drf36 | 90% <100%> (-0.32%) |
:arrow_down: |
#drf37 | 89.14% <100%> (?) |
|
#drf38 | 89.14% <100%> (?) |
|
#py27 | 90.36% <100%> (-0.31%) |
:arrow_down: |
#py33 | ? |
|
#py34 | 90% <100%> (+0.5%) |
:arrow_up: |
#py35 | 87.07% <100%> (?) |
|
#py36 | 89.14% <100%> (?) |
Impacted Files | Coverage Δ | |
---|---|---|
tests/test_serializers.py | 95.45% <100%> (+0.14%) |
:arrow_up: |
rest_framework_jwt/utils.py | ||
rest_framework_jwt/models.py |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 0a0bd40...8fe0b2c. Read the comment docs.
Can I have any feedback on this pull request? Also, are you moving the project to GitLab or staying on GitHub?
Hello.
I updated the test skip in
test_serializers
as it was comparing the Django version to 1.10 by checking only the second digit, which fails for Django 2.0. I also updated the tox.ini, .travis.yml and the documentation accordingly.I removed the 3.3 tests as it fails the test (can't create the virtualenv, the bug is found here: https://github.com/tox-dev/tox/issues/644).