search

jpadilla / django-rest-framework-jwt

JSON Web Token Authentication support for Django REST Framework
http://jpadilla.github.io/django-rest-framework-jwt/
MIT License
3.19k stars 652 forks source link

please pass request param to django.contrib.auth.authenticate #455

Open mqinbin opened 6 years ago

mqinbin commented 6 years ago

for some reason i want to use "request" in AUTHENTICATION_BACKENDS but i got request as None

i need request because:

  1. shopping cart is in cookie before login
  2. shoping cart is in server after login
  3. i want to decorate anywhere when login ( logon 、login 、oauth2)
  4. in my decoration : i get user from request
  5. i write a new AUTHENTICATION_BACKENDS give User to request as user property no request no user

just change you serializers line 50 from user = authenticate(credentials) to user = authenticate(self.context["request"] , credentials)

thanks

ehmadzubair commented 5 years ago

@jpadilla If i create a PR, will this be merged?

string-areeb commented 5 years ago

No, most likely not. Project hasn't been updated for 2 years. https://github.com/jpadilla/django-rest-framework-jwt/issues/484 Use https://github.com/davesque/django-rest-framework-simplejwt/ or https://github.com/Styria-Digital/django-rest-framework-jwt instead