search

jpadilla / django-rest-framework-oauth

OAuth support for Django REST Framework
http://jpadilla.github.io/django-rest-framework-oauth
BSD 3-Clause "New" or "Revised" License
59 stars 22 forks source link

Make OAuth packages optional #12

Closed rlucioni closed 8 years ago

rlucioni commented 8 years ago

In most cases, only one OAuth package is necessary. This PR is a successor to https://github.com/jpadilla/django-rest-framework-oauth/pull/8, which made a similar change but didn't fix tests.

@jpadilla could you please review this? Let me know if you have any questions.

jpadilla commented 8 years ago

@rlucioni Thanks! We also need to update setup.py.

rlucioni commented 8 years ago

@jpadilla no problem. What in particular do we need to update in setup.py? python setup.py test succeeds after having installed the contents of requirements-test.txt.

jpadilla commented 8 years ago

@rlucioni https://github.com/jpadilla/django-rest-framework-oauth/blob/master/setup.py#L17

rlucioni commented 8 years ago

@jpadilla got it. Does it make sense to keep requirements.txt around given that it's now empty? I wasn't sure about deleting it.

rlucioni commented 8 years ago

@jpadilla I've updated setup.py.

jpadilla commented 8 years ago

@rlucioni Reviewing this more closely. Probably need some doc updates, right? What are the steps to get up and going after installing this package?

rlucioni commented 8 years ago

@jpadilla good call. I've updated the docs.

rlucioni commented 8 years ago

@jpadilla anything else I can do to help land this?

jpadilla commented 8 years ago

@rlucioni thanks! I'll cut out a release today.

rlucioni commented 8 years ago

@jpadilla that'd be great, thank you very much!

jpadilla commented 8 years ago

@rlucioni v1.1.0 is out, thanks again for everything! :fireworks:

rlucioni commented 8 years ago

@jpadilla awesome, thanks for the quick response.