search

jpadilla / notaso

Conoce a tus profesores antes de llegar al salón.
http://www.notaso.com/
Other
19 stars 6 forks source link

Python 3.7 + Django 2 #107

Closed jpadilla closed 4 years ago

jpadilla commented 6 years ago

NOT READY TO MERGE

@rnegron Started working on this, still haven't gone through everything but we're almost there!

rnegron commented 5 years ago

Started on some unittests (#16). There doesn't seem to be anything blocking Python 3.7 at first glance. More testing would be good (forms, views, plus some integration tests with Selenium?)

jpadilla commented 5 years ago

giphy

Awesome work! Honestly, I wouldn't really invest the time/resources on integration tests with Selenium or with too many unit tests, just cover some of the most critical paths and that's it. Just enough to help with maintenance. Newer features should ideally have some tests as well.

jpadilla commented 5 years ago

@rnegron que hacemos con esto, merge/deploy it?

rnegron commented 5 years ago

Este fin de semana le hecho un vistazo y hago algunos otros unittests. Luego de eso lo podemos merge yo creo

rnegron commented 5 years ago

Updated some packages that pipenv check gave warnings about. For the "django-storages" update, a new env var AWS_DEFAULT_ACL should be set on the deploy environment! Didn't get a chance to add more unittests, but will soon

rnegron commented 4 years ago

1 year later! @jpadilla What do you think? I got passing tests on my side.