jpadilla / pyjwt

JSON Web Token implementation in Python
https://pyjwt.readthedocs.io
MIT License
5.08k stars 679 forks source link

Add cacheing functionality for JWK set #781

Closed wuhaoyujerry closed 2 years ago

wuhaoyujerry commented 2 years ago

Problem

The current PyJWT library only support caching of single signing key. Ref to https://github.com/jpadilla/pyjwt/pull/611

Even though it avoids the network call when the services periodically calling get_signing_key with same kid, the current implementation doesn't have any TTL, so the cache is stored forever. Also, it still makes network call when different kid is provided.

Solution & Implantation

wuhaoyujerry commented 2 years ago

Hi @auvipy, this PR has been approved for a while. Any idea when it can be merged? Let me know if you have any questions.

wuhaoyujerry commented 2 years ago

Thx for merging the PR @auvipy, do you have an estimation time on when the new release will be published? My team want to use some features in the master branch and kinda been blocked right now.

jpadilla commented 2 years ago

Before releasing this I think we'd need an updated changelog and I think this probably deserves at least some docs.

wuhaoyujerry commented 2 years ago

I can add some docs about this functionality

dwyfrequency commented 1 year ago

Is there a timeline for when this feature will be released to production?

mactanner commented 9 months ago

I can add some docs about this functionality

Where can the docs be found? Thanks for this feature.