search

jpadilla / pyjwt

JSON Web Token implementation in Python
https://pyjwt.readthedocs.io
MIT License
5.11k stars 684 forks source link

Allows passing of ssl.SSLContext to PyJWKClient #891

Closed juur closed 1 year ago

juur commented 1 year ago

Allows passing of ssl.SSLContext to PyJWKClient. This can be used, for example, to have a custom CA.

juur commented 1 year ago

I'm unsure why that one specific check failed (pypy-3.8 on windows-latest) ...

juur commented 1 year ago

Any comments or issues?

michaelhenry commented 1 year ago

@jpadilla @auvipy

Do you have any updates on this?

Weirdly, it failed on one of the tests considering that the urllib.request.urlopen() has default None context from https://github.com/python/cpython/blob/9d35a71a76cb033598ce136ea655d9e452fe3af0/Lib/urllib/request.py#L138 . Is the test failure is just a glitch? How about restarting it?

juur commented 1 year ago

can you please add proper test case to verify the changes proposed?

I'll have a go for sure.

juur commented 1 year ago

I've added some tests, don't know why 3.8 on windows fails.

juur commented 1 year ago

I've added some tests, don't know why 3.8 on windows fails.

Also didn't mean to close the pull, oops.

TrueBrain commented 1 year ago

@auvipy just for your information, as this PR title ended up in your release notes: Patch 1 kinda raised some eyebrows :P If possible, it might be good to change the PR title before generating release changelogs next time (or fix it in the release notes, ofc). Not a real trouble, I now just had to click the link to find out what happened :)

And yes, just in case anyone was wondering if someone actually reads those release notes .. yes, we do :) To spot breaking changes that might require attention, mostly.

Screenshot for context: image

auvipy commented 1 year ago

good suggestion. thanks