search

jpadilla / pyjwt

JSON Web Token implementation in Python
https://pyjwt.readthedocs.io
MIT License
5k stars 675 forks source link

Specify ca file from certifi #893

Closed michaelhenry closed 1 year ago

michaelhenry commented 1 year ago

close #892

michaelhenry commented 1 year ago

@auvipy thanks for the review. Is it okay if execute an actual request? because the urllib.request.urlopen was mocked, but not sure how to validate the root certificate without executing the actual request. Any guidance on this part? thanks

jpadilla commented 1 year ago

I'm not sure I see the value of including an additional dependency here. I'd rather see https://github.com/jpadilla/pyjwt/pull/891 get in

michaelhenry commented 1 year ago

@jpadilla true, that one is more dynamic. I can close this pr and hopefully to merge it soon. Thanks

michaelhenry commented 1 year ago

Closing this pr with respect to #891